codereview培训手册training_phase_07_code_review讲义教材.pptx

Parasoft Concerto TrainingPhase 7 – Code Review2012Why do Code Review?Parasoft Proprietary and ConfidentialFind defects earlyFind real functional problemsIncrease breadth of understandingLeads to increased productivityMethods of Code ReviewParasoft Proprietary and ConfidentialCode Review “in a room”Wastes timeDevelopers are inhibitedUsing an automated infrastructureconsistentPutting it togetherParasoft Proprietary and ConfidentialThe next slides show how to do itPlanningSetting up tasksPerforming the workTwo methods for code reviewPre-commitPost-commitFirst phase of code review should be pre-commitDetermining ReviewersWho reviews whomHow close are they in the code?Increase code understandingParasoft Proprietary and ConfidentialWhen to use pre-commitParasoft Proprietary and ConfidentialShouldn’t be for normal experienced developersSetup policies to determine when to useNew developersNew team membersSignificant code changesMore than 2-3 files for a single fixCode Review WorkflowParasoft Proprietary and ConfidentialWhen is it enough?Parasoft Proprietary and ConfidentialWhen everyone agreesPre-commit will hold up other development effortsBalance between full review and getting things doneCode Review HistoryParasoft Proprietary and ConfidentialConcerto stores everythingGreat for accountabilityWhat what you sayCONCERTO CR HISTORY DEMOReview ClassificationsParasoft Proprietary and ConfidentialReading the Review GraphParasoft Proprietary and ConfidentialReview Task ClassificationParasoft Proprietary and ConfidentialNew issues by severityReviewer classifiesNew issues by categoryReviewers TasksParasoft Proprietary and ConfidentialReviews and code baseParasoft Proprietary and ConfidentialWhat shouldn’t you look atParasoft Proprietary and ConfidentialCode formation use static analysisBeautificationNaming conventions Some are related to functionality – check thosePattern based should be checked in SAWhat should you look at?Parasoft Proprietary and ConfidentialMetrics violationsT